feat(utils): findLastKey 함수 추가 #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c8f9926 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sangminnn
commented
Oct 18, 2024
| condition: (value: T[keyof T]) => boolean, | ||
| ): string | undefined { | ||
| const keys = Object.keys(obj); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
reverse 함수를 사용할 경우 불필요하게 한번 더 순회하여 성능적 이점을 가지고가기 위해 아래의 방식을 사용했습니다.
실제 reverse 함수를 사용했을때보다 실제로 성능적 이점이 있는 부분을 확인했습니다.
reverse 사용 O
reverse 사용 X
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
==========================================
+ Coverage 97.41% 97.60% +0.18%
==========================================
Files 164 173 +9
Lines 1470 1542 +72
Branches 361 387 +26
==========================================
+ Hits 1432 1505 +73
+ Misses 34 33 -1
Partials 4 4
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Issue: #450
객체에서 조건에 부합하는 마지막 key를 반환합니다.
PR Checklist
Contributing Guide